Update CauseMappings to reflect issue 634 - support transitions not correctly #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyspendedToRead caused by Reset remains as per Part 10 Table 7
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2877 +/- ##
==========================================
- Coverage 55.33% 55.27% -0.06%
==========================================
Files 352 352
Lines 67343 67343
Branches 13808 13808
==========================================
- Hits 37262 37225 -37
- Misses 26002 26034 +32
- Partials 4079 4084 +5 ☔ View full report in Codecov by Sentry. |
mregen
approved these changes
Dec 3, 2024
mregen
pushed a commit
that referenced
this pull request
Dec 3, 2024
SyspendedToRead caused by Reset remains as per Part 10 Table 7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SyspendedToRead caused by Reset remains as per Part 10 Table 7
Proposed changes
ProgramStateMachineState Transitions Updated
RunningToReady on Reset should not be available, and has been removed
ReadyToHalted on Halt is missing, and has been added
SuspendedToReady on Reset is more obscure, but Table 7 suggests that this should be valid, so no changes have been made
Related Issues
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.